huncode/content-factory
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

task015 implement seo and language review flow

Browse Source
This commit is contained in:
huncode
2026-05-22 00:16:08 +03:00
parent 8243f20b0e
commit 6dcbe0e36c
20 changed files with 3828 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tasks/015-seo-and-language-review.md
+45 -14
View File
@@ -46,14 +46,14 @@ Development description: Implement SEO and linguistic review jobs, issue reports
## Acceptance Criteria
- [ ] TDD pre-requirement: before implementation, write one failing behavior test that runs an SEO review and returns a visible issue through the public API; proceed one review behavior at a time and record evidence in `Result`.
- [ ] SEO report includes score, issues, suggested fixes, recommended slug/title, and schema JSON.
- [ ] Language report includes severity, location, message, and suggested rewrite.
- [ ] Editor can accept, reject, or edit each suggestion.
- [ ] Accepted content changes create a new immutable draft version.
- [ ] Target-site SEO and tone rules override global defaults.
- [ ] Final review can show unresolved SEO/language issues.
- [ ] Fake review runner produces deterministic demo reports.
- [x] TDD pre-requirement: before implementation, write one failing behavior test that runs an SEO review and returns a visible issue through the public API; proceed one review behavior at a time and record evidence in `Result`.
- [x] SEO report includes score, issues, suggested fixes, recommended slug/title, and schema JSON.
- [x] Language report includes severity, location, message, and suggested rewrite.
- [x] Editor can accept, reject, or edit each suggestion.
- [x] Accepted content changes create a new immutable draft version.
- [x] Target-site SEO and tone rules override global defaults.
- [x] Final review can show unresolved SEO/language issues.
- [x] Fake review runner produces deterministic demo reports.
## Verification
@@ -64,9 +64,40 @@ Development description: Implement SEO and linguistic review jobs, issue reports
## Result
- Status: Pending execution.
- TDD plan: To be filled during execution.
- Red evidence: To be filled during execution.
- Green evidence: To be filled during execution.
- Refactor notes: To be filled during execution.
- Verification output: To be filled during execution.
- Status: Completed (pre-requirement RED + implementation GREEN).
- TDD plan (done):
1. Prepare article through public flow to assembled draft state.
2. Run SEO and language review via public endpoints.
3. Fetch reports and verify issue visibility through API.
4. Apply suggestion actions (accept/reject/edit) and verify immutable draft versioning.
5. Verify unresolved issues in final review context and deterministic fake-runner behavior.
- Red evidence:
- Pre-requirement test initially failed with `404 Not Found` on `POST /api/articles/{article_id}/seo/review`.
- Green evidence:
- Added review domain contracts, persistence tables, repository, application service, and routes:
- `POST /api/articles/{article_id}/seo/review`
- `GET /api/articles/{article_id}/seo/report`
- `POST /api/articles/{article_id}/language/review`
- `GET /api/articles/{article_id}/language/report`
- suggestion actions:
- `POST /api/articles/{article_id}/seo/suggestions/{suggestion_id}/accept|reject|edit`
- `POST /api/articles/{article_id}/language/suggestions/{suggestion_id}/accept|reject|edit`
- unresolved issues endpoint:
- `GET /api/articles/{article_id}/final-review/issues`
- Reports are generated deterministically from assembled draft + site rules and stored in review tables.
- Accept/edit actions that modify content/metadata create a new immutable draft version through existing draft versioning flow.
- Site-level overrides are applied from `target_sites.seo_rules` (`seo_review` / `language_review`) over defaults.
- Added frontend review feature model + UI and API bindings.
- Regenerated shared contracts:
- `packages/shared/openapi.json`
- `packages/shared/src/api-types.ts`
- Refactor notes:
- `ContentReviewReportSummary.schema_json` currently emits a pydantic shadow warning; behavior is correct and contracts remain stable.
- Verification output:
- `PYTHONPATH=/private/tmp/pupline-backend-deps python3 -m unittest apps/backend/tests/integration/test_seo_language_review_public_api.py` -> `OK (6 tests)`
- `PYTHONPATH=/private/tmp/pupline-backend-deps python3 -m unittest apps/backend/tests/integration/test_draft_assembly_public_api.py` -> `OK (5 tests)`
- `PYTHONPATH=/private/tmp/pupline-backend-deps python3 -m unittest apps/backend/tests/integration/test_assets_media_library_public_api.py` -> `OK (7 tests)`
- `node apps/frontend/tests/draft_editor.model.test.mjs` -> `OK`
- `node apps/frontend/tests/article_assets.model.test.mjs` -> `OK`
- `node apps/frontend/tests/article_review.model.test.mjs` -> `OK`
- `pnpm --dir apps/frontend typecheck` -> `OK`