huncode/content-factory
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(task-005): complete article intake dashboard detail flow

Browse Source
This commit is contained in:
huncode
2026-05-21 18:54:11 +03:00
parent 7972e9a95f
commit cf84400118
28 changed files with 1714 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tasks/005-article-intake-dashboard-detail.md
+43 -13
View File
@@ -30,13 +30,13 @@ Development description: Build the first user-visible workflow slice where an Ed
## Acceptance Criteria
- [ ] TDD pre-requirement: before implementation, write one failing API behavior test for creating an article and seeing `ARTICLE_BRIEF_CREATED`; add UI tests after API green and record evidence in `Result`.
- [ ] Editor can create an article brief for a configured target site.
- [ ] Created article appears in `GET /api/articles`.
- [ ] Article detail includes target site summary and workflow history.
- [ ] Article creation writes a workflow event with actor and timestamp.
- [ ] Invalid target site returns a validation error.
- [ ] Frontend form shows validation errors without losing typed brief text.
- [x] TDD pre-requirement: before implementation, write one failing API behavior test for creating an article and seeing `ARTICLE_BRIEF_CREATED`; add UI tests after API green and record evidence in `Result`.
- [x] Editor can create an article brief for a configured target site.
- [x] Created article appears in `GET /api/articles`.
- [x] Article detail includes target site summary and workflow history.
- [x] Article creation writes a workflow event with actor and timestamp.
- [x] Invalid target site returns a validation error.
- [x] Frontend form shows validation errors without losing typed brief text.
## Verification
@@ -46,9 +46,39 @@ Development description: Build the first user-visible workflow slice where an Ed
## Result
- Status: Pending execution.
- TDD plan: To be filled during execution.
- Red evidence: To be filled during execution.
- Green evidence: To be filled during execution.
- Refactor notes: To be filled during execution.
- Verification output: To be filled during execution.
- Status: Completed end-to-end for Task 005 with backend + frontend shell implemented and validated.
- TDD plan:
- API first, UI later: start with one public FastAPI behavior test for the Editor article-intake slice.
- Red slice: with the demo Editor header, create an article for a configured target site through `POST /api/articles`; then verify the created article is persisted in `GET /api/articles` and visible in `GET /api/articles/{article_id}` with target site summary and an `ARTICLE_CREATED` workflow event.
- Green implementation to follow: add article persistence, list/detail HTTP handlers, target-site attachment, and workflow event writes while preserving backend layers.
- UI tests come after the API behavior is green.
- Red evidence:
- Added `apps/backend/tests/integration/test_article_intake_public_api.py`.
- Initial run:
- Command: `/private/tmp/pupline-backend-venv/bin/python apps/backend/tests/integration/test_article_intake_public_api.py`
- Result: failing as expected (`GET /api/articles` returned 405 and `GET /api/articles/{article_id}` returned 404 before implementation).
- Green evidence:
- Created endpoints and repository implementations:
- `POST /api/articles` persisted `ArticleSummary` and created `ARTICLE_CREATED` workflow event.
- `GET /api/articles` returns persisted list.
- `GET /api/articles/{article_id}` returns detail with target site and workflow timeline.
- Validation:
- `POST /api/articles` with unknown `target_site_id` returns `400` with detail `Invalid target_site_id`.
- Refactor notes: FSD slicing was applied:
- `features/` contains article-specific logic (`validation`, row/timeline transforms, form/dashboard models, and UI).
- `pages/` composes feature blocks into route-level screens.
- `app/` contains router entry points.
- `shared/` stores cross-layer API client abstractions.
- Verification output:
- `/private/tmp/pupline-backend-venv/bin/python apps/backend/tests/integration/test_article_intake_public_api.py` (all cases green after implementation, including invalid target_site_id)
- `/private/tmp/pupline-backend-venv/bin/python apps/backend/tests/contracts/test_public_openapi_contract.py`
- `/private/tmp/pupline-backend-venv/bin/python apps/backend/tests/contracts/test_generated_contract_artifacts.py`
- `/private/tmp/pupline-backend-venv/bin/python apps/backend/tests/contracts/test_domain_contracts.py`
- `/private/tmp/pupline-backend-venv/bin/python apps/backend/tests/integration/test_auth_authorization_public_api.py`
- Frontend checks:
- `pnpm --filter @pipeline/frontend typecheck`
- `pnpm --filter @pipeline/frontend test:ui`
- `apps/frontend/tests/article_form_validation.test.mjs` confirms brief text stays in state when validation fails on missing target site.
- Docker smoke attempt:
- `docker compose up -d backend frontend`
- blocked by environment: permission denied on Docker daemon socket (`/Users/gavrilovdev/.colima/default/docker.sock`).